Skip to content

[CI] Add pip dependence explicitly #28008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

[CI] Add pip dependence explicitly #28008

merged 1 commit into from
Aug 21, 2019

Conversation

makbigc
Copy link
Contributor

@makbigc makbigc commented Aug 19, 2019 •
edited
Loading

Close #27374. Get rid of the conda warning.

@datapythonista datapythonista added CI Continuous Integration Dependencies Required and optional dependencies labels Aug 19, 2019
@datapythonista
Copy link
Member

@makbigc can you add it to the other CI deps too? If it makes sense to have it for that build, I guess it makes sense to have it in all them (and also environment.yml).

Thanks!

CC: @TomAugspurger

@TomAugspurger
Copy link
Contributor

Agreed with doing it for all the env files.

@makbigc
Copy link
Contributor Author

makbigc commented Aug 20, 2019

Added in other builds. And pip is already added in environment.yml.

pandas/environment.yml

Line 55 in e118b1d

- pip

@datapythonista
Copy link
Member

Sorry I wasn't very specific @makbigc, but I meant to add it to the dependency files where pip is being used, we don't need it in the files where there are no pip dependencies. For what you say I guess it was only missing in the file you initially changed. Sorry about that.

@makbigc
Copy link
Contributor Author

makbigc commented Aug 20, 2019

It doesn't matter. I haven't done a lot of work.
azure-macos-35.yaml is the only file which doesn't specify pip dependence explicitly but use pip to install other packages.

datapythonista
datapythonista approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks @makbigc.

@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 21, 2019
@TomAugspurger TomAugspurger merged commit e4c4b78 into pandas-dev:master Aug 21, 2019
@TomAugspurger
Copy link
Contributor

Thanks!

galuhsahid pushed a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
@makbigc @galuhsahid
CI: Add pip dependence explicitly (pandas-dev#28008)
e90bc7b
galuhsahid added a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
@galuhsahid
Merge branch 'master' into parquet-categorical
1e3df80 
* master: (40 commits)
  DOC: Fix GL01 and GL02 errors in the docstrings (pandas-dev#27988)
  Remove Encoding of values in char** For Labels (pandas-dev#27618)
  TYPING: more type hints for io.formats.printing (pandas-dev#27765)
  TST: fix compression tests when run without virtualenv/condaenv (pandas-dev#28051)
  DOC: Start 0.25.2 (pandas-dev#28111)
  DOC: Fix docstrings lack of punctuation (pandas-dev#28031)
  DOC: Remove alias for numpy.random.randn from the docs (pandas-dev#28082)
  DOC: update GroupBy.head()/tail() documentation (pandas-dev#27844)
  BUG: timedelta merge asof with tolerance (pandas-dev#27650)
  BUG: Series.rename raises error on values accepted by Series construc… (pandas-dev#27814)
  Preserve index when setting new column on empty dataframe. (pandas-dev#26471)
  BUG: Fixed groupby quantile for listlike q (pandas-dev#27827)
  BUG: iter with readonly values, closes pandas-dev#28055 (pandas-dev#28074)
  TST: non-strict xfail for period test (pandas-dev#28072)
  DOC: Update whatsnew (pandas-dev#28073)
  CI: disable codecov (pandas-dev#28065)
  CI: Set SHA for codecov upload (pandas-dev#28067)
  BUG: Correct the previous bug fixing on xlim for plotting (pandas-dev#28059)
  CI: Add pip dependence explicitly (pandas-dev#28008)
  DOC: Change document code prun in a row (pandas-dev#28029)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

CI: conda warning
3 participants
@makbigc @datapythonista @TomAugspurger