Hack fix for BUG - GH24784 #28003
Closed
Hack fix for BUG - GH24784 #28003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using any of the Locators the date calculation (x-axis labels) are off by one day in case of continuous dates.
When using any of the Locators the date calculation (x-axis labels) are off by one day when continuous dates are provided.
When using any of the Locators the date calculation (x-axis labels) are off by one day when continuous dates are provided.
|
Hello @itssujeeth! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-08-18 18:52:40 UTC |
mroeschke
requested changes
Aug 18, 2019
| @@ -270,6 +270,13 @@ def _get_index_freq(data): | |||
| weekdays = np.unique(data.index.dayofweek) | |||
| if (5 in weekdays) or (6 in weekdays): | |||
| freq = None | |||
| # This is a hack introduced to avoid tick resolution adjustment issue - | |||
There was a problem hiding this comment.
This fix feels too specific. Guessing the fix might be in _use_dynamic_x where the locators are calculated
There was a problem hiding this comment.
yes, the _use_dynamic_x is causing the locators to be off by one day if consecutive dates are provided.
|
can you merge master and update to comments |
|
closing this as stale, though its a nice change, needs a rebase and comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff