Support str param type for partition_cols in to_parquet function #27984
Conversation
Issue 27117
| partition_cols : list or string, optional, default None | ||
| Column names by which to partition the dataset. | ||
| Columns are partitioned in the order they are given. | ||
| String identifies a single column to be partitioned. | ||
|
|
||
| .. versionadded:: 0.24.0 |
There was a problem hiding this comment.
Can you add a .. versionchanged:: 1.0.0 explaining that passing a single string was added in 1.0?
There was a problem hiding this comment.
I think I added it correctly. This is my first contribution so bear with me please :)
There was a problem hiding this comment.
You can put the .. versionchanged:: ... right below the parameter explanation (so since there is already a ..versionadded:: 0.24.0, it would go just below that
| partition_cols : list or string, optional, default None | ||
| Column names by which to partition the dataset. | ||
| Columns are partitioned in the order they are given. | ||
| String identifies a single column to be partitioned. | ||
|
|
||
| .. versionadded:: 0.24.0 |
There was a problem hiding this comment.
You can put the .. versionchanged:: ... right below the parameter explanation (so since there is already a ..versionadded:: 0.24.0, it would go just below that
| @@ -29,7 +29,7 @@ Enhancements | |||
| Other enhancements | |||
| ^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - | |||
| - String support for paramater partition_cols in the :func:`pandas.to_parquet` (:issue:`27117`) | |||
There was a problem hiding this comment.
| - String support for paramater partition_cols in the :func:`pandas.to_parquet` (:issue:`27117`) | |
| - String support for paramater ``partition_cols`` in the :func:`pandas.to_parquet` (:issue:`27117`) |
I would also try to make it a bit clearer to say that a string for a single column name is now also accepted instead of a list
There was a problem hiding this comment.
do we really want to accept a sting here (and not a list)? i think we would rather be strict about this; though i suppose this is convenient as a partition col is often a single str
Co-Authored-By: Joris Van den Bossche <[email protected]>
|
@DalynnHatch can you merge master; the code change is ok, but will comment on the tests after rebase. |
|
Closing as stale but @DalynnHatch ping if you'd like to pick back up and continue |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffNot sure where to add whatsnew entry #PandasHack2019