Skip to content

test case for transform with fillna #27905 #27974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

test case for transform with fillna #27905 #27974

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
599b842
test case for transform with fillna
Aug 17, 2019
3d21f66
corrected code review comments
Aug 17, 2019
1b372ae
fillna testing
Aug 17, 2019
873b198
test fillna in groupby.transform
Aug 17, 2019
b56a30d
test with numbers
Aug 17, 2019
b3a1ef5
errors fix
Aug 17, 2019
2c5f611
errors rectification
Aug 17, 2019
02cf60e
linting error
Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions pandas/tests/groupby/test_transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,3 +1074,32 @@ def test_transform_lambda_with_datetimetz():
name="time",
)
assert_series_equal(result, expected)


@pytest.mark.parametrize(
"inputDF, expectedDF",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputDF -> input_df
expectedDF -> expected_df

are there other dtypes we should be testing?

[
(
DataFrame(
{
"A": [121, 121, 121, 121, 231, 231, 676],
"B": [1, 2, np.nan, 3, 3, np.nan, 4],
}
),
1,
),
(
DataFrame(
{
"A": [121, 121, 121, 121, 231, 231, 676],
"B": [1.0, 2.0, 2.0, 3.0, 3.0, 3.0, 4.0],
}
),
1,
),
],
)
def test_groupby_transform_fillna(inputDF, expectedDF):
# GH 27905 - Test fillna in groupby.transform
input1 = inputDF.groupby("A").transform(lambda x: x.fillna(x.mean()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the forms

result =
tm.assert_frame_equal(result, expected)

assert all(input1 == expectedDF)