Added try-except clause to catch numpy error. #27970
Conversation
|
needs a test |
|
Modified as requested. |
|
by "needs a test" I meant that this PR fixes some bug and we need a unit test (goes somewhere in pandas/tests/) to test that we get the correct behavior |
gfyoung
added
Constructors
|
I added a test in a place that seemed appropriate. It passed on my platform. |
|
The last version didn't pass the checks. I'm confused because the error doesn't seem to be related to anything that I edited...
|
| @@ -69,6 +69,10 @@ def test_empty_frame_dtypes_ftypes(self): | |||
| norows_df = pd.DataFrame(columns=list("abc")) | |||
| assert_series_equal(norows_df.dtypes, pd.Series(np.object, index=list("abc"))) | |||
|
|
|||
| cat = pd.CategoricalDtype() | |||
There was a problem hiding this comment.
Could you add tests for other extension dtypes (e.g. datetime with timezones and/or period)
| @@ -223,7 +223,9 @@ def init_dict(data, index, columns, dtype=None): | |||
|
|
|||
| # no obvious "empty" int column | |||
| if missing.any() and not is_integer_dtype(dtype): | |||
| if dtype is None or np.issubdtype(dtype, np.flexible): | |||
| if is_categorical_dtype(dtype): | |||
There was a problem hiding this comment.
Based on the original issue this needs to be is_extension_array_dtype.
|
can you merge master and add a test |
|
closing this as stale, though its a nice change, needs a rebase and comments addressed. |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff