BUG: don't cache pandas matplotlib converters (#27036) #27968
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amerberg
changed the title
| @@ -67,7 +67,13 @@ def register(explicit=True): | |||
| converter = cls() | |||
| if type_ in units.registry: | |||
| previous = units.registry[type_] | |||
| _mpl_units[type_] = previous | |||
| # Exclude our converters from caching to make this idempotent. | |||
| if type(previous) not in { | |||
There was a problem hiding this comment.
the preferred way to do this check would be if not isinstance(previous, ...)
There was a problem hiding this comment.
... though now that i look below, it looks like someone else used this pattern before, so never mind
|
Can you add a test for the bugfix |
|
How does this interact with #27481? |
|
I believe this addresses the same issue as #27481, so I'm closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff#27036 is caused by pandas converters replacing default converters in the cache when we register our matplotlib converters.