Skip to content

BUG: set_precision format fixed (#13257) #27934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2019
Merged

BUG: set_precision format fixed (#13257) #27934

merged 3 commits into from
Oct 22, 2019

Conversation

AntonioAndraues
Copy link
Contributor

@AntonioAndraues AntonioAndraues commented Aug 15, 2019 •
edited by WillAyd
Loading

I've tried to fix the set_precision format, does that fix it?

INPUT -> df.style.set_precision(2)

A B
1 2.0090
3.2121 4.566

OUTPUT

A B
1 2.01
3.21 4.57

@ViniGl
@Samuelgranato

@pep8speaks
Copy link

pep8speaks commented Aug 15, 2019 •
edited
Loading

Hello @AntonioAndraues! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-16 14:57:46 UTC

@jbrockmendel
Copy link
Member

Can you add a test for this

@AntonioAndraues AntonioAndraues force-pushed the issue-13257 branch 4 times, most recently from 751c317 to 65fba0e Compare August 19, 2019 18:31
@AntonioAndraues
Copy link
Contributor Author

Can you add a test for this

I just added a test.
Is that it?

@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 19, 2019
@TomAugspurger TomAugspurger added Output-Formatting __repr__ of pandas objects, to_string Code Style Code style, linting, code_checks labels Aug 19, 2019
TomAugspurger
TomAugspurger reviewed Aug 19, 2019
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a release note to doc/source/whatsnew/v1.0.0.rst under "bug fixes"? Probably the "Other" section.

@AntonioAndraues
Copy link
Contributor Author

Looks good. Can you add a release note to doc/source/whatsnew/v1.0.0.rst under "bug fixes"? Probably the "Other" section.

Done

@AntonioAndraues AntonioAndraues force-pushed the issue-13257 branch 2 times, most recently from 8931f62 to b7d8fc8 Compare August 21, 2019 16:29
@AntonioAndraues AntonioAndraues force-pushed the issue-13257 branch 2 times, most recently from 708b140 to 0aeb419 Compare August 22, 2019 12:17
@TomAugspurger
Copy link
Contributor

Thanks. Looks like there's a merge conflict in 1.0.0.rst, if you could fix that.

@AntonioAndraues
Copy link
Contributor Author

AntonioAndraues commented Sep 5, 2019 •
edited
Loading

Thanks. Looks like there's a merge conflict in 1.0.0.rst, if you could fix that.
@TomAugspurger
I think i fix it.

@TomAugspurger
Copy link
Contributor

CI is failing now. Do your tests need to be updated?

@AntonioAndraues
Copy link
Contributor Author

CI is failing now. Do your tests need to be updated?
@TomAugspurger
I'm sorry forgot to update them...
I think everything will be fine now!

@TomAugspurger
Copy link
Contributor

Hmm CI is still failing. Haven't taken a look though.

@AntonioAndraues AntonioAndraues force-pushed the issue-13257 branch 2 times, most recently from d9c7550 to ec08677 Compare September 19, 2019 11:22
@AntonioAndraues AntonioAndraues force-pushed the issue-13257 branch 3 times, most recently from 2636b5d to 13ac21a Compare September 19, 2019 11:41
@AntonioAndraues
Copy link
Contributor Author

AntonioAndraues commented Sep 19, 2019 •
edited
Loading

Hmm CI is still failing. Haven't taken a look though.
I think CI is failing because some test from others contributors are expecting the older use of style...
Do i change the test?

Captura de Tela 2019-09-19 às 09 34 27

@TomAugspurger

@WillAyd
Copy link
Member

WillAyd commented Sep 19, 2019

If the old test is wrong then for sure should update

@WillAyd
Copy link
Member

WillAyd commented Oct 11, 2019

@AntonioAndraues is this still active? If so can you fix up merge conflict?

@AntonioAndraues
Copy link
Contributor Author

@WillAyd Yes. I Will fix it...
Sunday in the afternoon i commit it.

@AntonioAndraues AntonioAndraues force-pushed the issue-13257 branch 4 times, most recently from 8596e7c to 9896176 Compare October 16, 2019 10:49
jreback
jreback requested changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. small changes; ping on green.

@simonjayhawkins simonjayhawkins added IO HTML read_html, to_html, Styler.apply, Styler.applymap and removed Code Style Code style, linting, code_checks labels Oct 21, 2019
@WillAyd WillAyd merged commit ef77b57 into pandas-dev:master Oct 22, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 22, 2019

Great thanks @AntonioAndraues - nice PR!

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
@AntonioAndraues
BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)
cf22fcb
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
@AntonioAndraues
BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)
8442843
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@AntonioAndraues @proost
BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)
b4d3902
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@AntonioAndraues @proost
BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)
d747932
@simonjayhawkins
Copy link
Member

I think this PR should be identified as a breaking change.

import pandas as pd
pd.__version__
df = pd.DataFrame([0.1])
df
df.style.highlight_min()

in pandas 0.25.1
image

on master
image

bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@AntonioAndraues
BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)
c8816d4
@ymzayek ymzayek mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger left review comments

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Pandas style.set_precision not working as expected
7 participants
@AntonioAndraues @pep8speaks @jbrockmendel @TomAugspurger @WillAyd @simonjayhawkins @jreback