Skip to content

TST: Asserts all types are caterogical in function fillna with correct error message #27933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 16, 2019
Merged

TST: Asserts all types are caterogical in function fillna with correct error message #27933

merged 5 commits into from
Aug 16, 2019

Conversation

LiuSeeker
Copy link
Contributor

@LiuSeeker LiuSeeker commented Aug 15, 2019 •
edited
Loading

@LiuSeeker LiuSeeker changed the title Fixes issue #13628 TST: Asserts all types are caterogical in function fillna with correct error message Aug 15, 2019
@jbrockmendel
Copy link
Member

needs isort pandas/tests/arrays/categorical/test_missing.py

@TomAugspurger TomAugspurger added this to the 0.25.1 milestone Aug 15, 2019
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite Categorical Categorical Data Type labels Aug 15, 2019
@TomAugspurger TomAugspurger modified the milestones: 0.25.1, 1.0 Aug 15, 2019
TomAugspurger
TomAugspurger approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to 1.0. Ping on green.

@jreback jreback merged commit 802f670 into pandas-dev:master Aug 16, 2019
@jreback
Copy link
Contributor

jreback commented Aug 16, 2019

thanks @LiuSeeker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Fillna a categories series with another series breaks
4 participants
@LiuSeeker @jbrockmendel @jreback @TomAugspurger