-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix regression in .ix fallback with IntervalIndex #27926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Opened #27927 |
really? we haven't patched .ix in many releases. And we are removing it. |
@jorisvandenbossche you work on windows right? can you reproduce the azure failure? |
No, sorry, no windows :) (linux) |
Then we maybe also shouldn't have tried to clean up the code .. ;) Anyway, this is just for 0.25.1, in master afterwards we can remove it again (when removing ix). |
Do I understand correctly: there is a bug in IntervalTree and fixing that would make this fix unnecessary? |
Yep. But I think that catching AttributeError here is a bit more conservative for the backport. |
Yes, I opened #27927 for that (the bug appears in other places as well, but there it was already failing before, so not a regression) |
Any objections to merge this? |
I think we're good. I had to restart the CI earlier for a failed build from the flaky test. |
@meeseeksdev backport to 0.25.x |
closes #27865
cc @jbrockmendel this is another one from limiting the catched exceptions in https://github.com/pandas-dev/pandas/pull/27223/files#diff-7489e290a23303c4db4f803011ecaf8eR121. But also this time it's again rather a bug in the code that raises this error.
For some reason,
DataFrame._get_value
for a DataFrame with an IntervalIndex raises an AttributeError. That's a bug in itself which should be solved (and probably is the cause of more bugs in other places where_get_value
is used, eg in.at
). But will open a separate issue for that.