-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Remove incorrect check, comment, rename #27922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b0cd06a
remove incorrect check
jbrockmendel 6dca9a5
avoid rename
jbrockmendel 140b1df
Merge branch 'master' of https://github.com/pandas-dev/pandas into woops
jbrockmendel b709f89
remove comment, fix check
jbrockmendel ac3b14e
Merge branch 'master' of https://github.com/pandas-dev/pandas into woops
jbrockmendel a68f8e6
re-comment
jbrockmendel 67df306
Update pandas/core/ops/__init__.py
jbrockmendel 0e46044
fix post-suggestion
jbrockmendel ca8fa6c
Merge branch 'master' of https://github.com/pandas-dev/pandas into woops
jbrockmendel 135f86d
Merge branch 'master' of https://github.com/pandas-dev/pandas into woops
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment is still not correct I think. As far as I know, result.name will always be None?
As mentioned in the original PR (https://github.com/pandas-dev/pandas/pull/27803/files#r311961558), I think it is here about self.name not being None.
The problem we were trying to solve is that finalize will put back the original name, which might be wrong. So that's the reason we can't pass
res_name
into_constructor
and afterwards dofinalize
, as that might change the name again.