-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Lambda function returns KeyError in DataFrameGroupBy.agg #27921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TomAugspurger
merged 26 commits into
pandas-dev:master
from
charlesdong1991:fix_issue_27519
Aug 30, 2019
Merged
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 1314059
fix conflicts
charlesdong1991 8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 e313083
fix issue 27519
charlesdong1991 197c879
Correct tests and add comments
charlesdong1991 b518b2f
Merge remote-tracking branch 'upstream/master' into fix_issue_27519
charlesdong1991 c817df2
Add whatsnew note
charlesdong1991 74d4684
fix test failure
charlesdong1991 7df87cb
Code change based on review
charlesdong1991 d5e52cb
Fix case for py35
charlesdong1991 5be9c54
More robust solution
charlesdong1991 29d8348
Simplify the code
charlesdong1991 275a039
Optimize the code
charlesdong1991 5dd61da
Simplify the code
charlesdong1991 b5b44e9
Simplify code
charlesdong1991 473800f
Add more complicated case to test result
charlesdong1991 bad1d72
Rename to make variable name meaningful
charlesdong1991 60e426a
Fix linting
charlesdong1991 943437a
Self review on code quality
charlesdong1991 a3ba061
Modify commet
charlesdong1991 a6719f1
Merge remote-tracking branch 'upstream/master' into fix_issue_27519
charlesdong1991 aabfcd2
Update doc
charlesdong1991 0950bc4
Better python
charlesdong1991 c992fec
Merge remote-tracking branch 'upstream/master' into fix_issue_27519
charlesdong1991 fe33469
Add test for make_unique
charlesdong1991 ace9035
fix linting
charlesdong1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify that the output example in the docstring still passes?
Can you also add a docstring example were this new code is hit in https://github.com/pandas-dev/pandas/pull/27921/files#diff-bfee1ba9e7cb79839776fac1a57ed940R1742?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, verified. And added tests for
_make_unique
function, all tests pass locally @TomAugspurger