-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Catch more specific exceptions in groupby #27909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thoughts here? Conflicts are going to start building up with local branches addressing catching-too-much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - more specific is certainly better with these
can you run groupby perf benchamarks. some of the code you changes was a sore point for perf recently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase & run groupby asvs
Rebased. asvs look like noise, which makes sense.
e.g. re-running |
Thanks! |
* catch stricter
* catch stricter
Working hypothesis is that this will help turn up the problem underlying #27902. Regardless catching more specific exceptions is worthwhile.