TST: Raise ValueError and suggestion to use header=None if header=-1 is pa… #27878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
negative-header
branch
from
66200bf to
878f550
Compare
MarcoGorelli
changed the title
Co-Authored-By: Tom Augspurger <[email protected]>
jreback
requested changes
Aug 15, 2019
gfyoung
reviewed
Aug 15, 2019
There was a problem hiding this comment.
@MarcoGorelli : This PR is off to a good start! If you can address @jreback's comment and expand the test, I think this will address the issue well.
…like object of non-negative integers), or None
|
Thanks @MarcoGorelli! |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 15, 2019
… use header=None if header=-1 is pa…
|
Happy to help, and massive thanks for your assistance/guidance! |
gfyoung
pushed a commit
that referenced
this pull request
Aug 16, 2019
…r=None if header=-1 is pa… (#27938)
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssed
header=-1inpandas.read_csv, or don't throw error #27779black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff