Skip to content

DOC: clarify see also for DataFrame.iterrows() #27875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DOC: clarify see also for DataFrame.iterrows() #27875

wants to merge 1 commit into from

Conversation

sameshl
Copy link
Contributor

@sameshl sameshl commented Aug 12, 2019

changed .x() to Dataframe.x() in See Also for DataFrame.iterrows.

changed ` .x()` to `Dataframe.x()` in seealso for DataFrame.iterrows.

closes #27892
@gfyoung gfyoung added the Docs label Aug 12, 2019
@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Aug 13, 2019
@jorisvandenbossche jorisvandenbossche changed the title DOC:See also for DataFrame.iterrows() DOC: clarify see also for DataFrame.iterrows() Aug 13, 2019
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Aug 13, 2019

@sameshl sorry, I just merged #27893, another PR that fixed the same issue. Because it was their first contribution, I merged the other one, but still, thanks a lot for your contribution, and sorry I didn't merge it.

BTW, one thing you can do to prevent this to some extent is to include a closes #27862 (with the issue number) in your PR. Then at least that shows up as a referenced PR in the issue, and other people that want to work on it might see that. You are also always welcome to explicitly mention on the issue that you are working on it.

@sameshl sameshl deleted the doc_iterrows branch August 13, 2019 08:13
@sameshl
Copy link
Contributor Author

sameshl commented Aug 13, 2019

@jorisvandenbossche No problem! I should have included the issue number in my PR. 😅
Giving beginners a chance should be the priority anyway. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants