Parametrize JSON tests #27838
Merged
Parametrize JSON tests #27838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if orient in ("values", "records"): | ||
| expected = expected.reset_index(drop=True) | ||
| if orient != "split": | ||
| expected.name = None |
There was a problem hiding this comment.
L837-L842 looks like it is the same as L810-L815, and really similar to 852-858, 883-884, possibly others. I guess this is what _check_orient used to be?
If this can be shared, that would be helpful. If not, comments to the effect of # this case does foo unlike in test_bar because of baz
| if dtype is False: | ||
| expected = dtSeries.copy() | ||
| else: | ||
| expected = self.objSeries.copy() |
There was a problem hiding this comment.
L832-L835 look different from the existing logic in _check_version. am i missing soemthing?
pandas/tests/io/json/test_pandas.py
Outdated
| ), | ||
| # bad key | ||
| ( | ||
| StringIO( |
There was a problem hiding this comment.
can/should the StringIO calls go inside the test?
There was a problem hiding this comment.
Yea I think that would make it more readable - nice idea!
pandas/tests/io/json/test_pandas.py
Outdated
| DataFrame([["a", "b"], ["c", "d"]], index=[1, 1], columns=["x", "y"]), | ||
| ), | ||
| ("records", DataFrame([["a", "b"], ["c", "d"]], columns=["x", "y"])), | ||
| ("values", DataFrame([["a", "b"], ["c", "d"]])), |
There was a problem hiding this comment.
would these be clearer if they conditionally did reset_index/columns in the test method to match the behavior in other tests? fine by me either way
There was a problem hiding this comment.
No yea this is also a great idea - would match the pattern in other tests better for sure
|
@WillAyd a handful of comments, generally LGTM. This is going to be much nicer when you're done here, thanks for doing it. |
|
OK last 3 commits should address outstanding comments. Let me know what you think and thanks again for the review |
|
@WillAyd LGTM, thanks. There are a couple of threads in the diff that are unresolved that would make for nice follow-ups, but nothing that is a blocker. Merging. |
This was referenced Sep 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Parametrized non unique column test * Parametrized non-unique index tests * Removed skip for values test * Blackify * Parametrized doubled_encoded_labels test * Parametrized 'biggie' test case * Parametrized basic test * simplified test names * int case * Parametrized categorical case * Parametrized empty test case * parametrized ts data * Parametrized mixed case * Removed unnecessary test * Blackify * moved position of dtype parametrization * Parametrized bad_data_raises test * broke off infinity test * parametrized precision test * parametrized infer words * Renamed df_orient to just orient for reuse * parametrized basic series test * Added default orient test * Parametrized empty series test * Parametrized series timeseries test * parametrized series numeric case * Removed unnecessary series roundtrip test * Parametrized date unit test * Parametrized utc test * parametrized ts_range_utc test * Removed py2 compat code * blackify * Parametrized infinity test * parametrized missing data test * Blackify * flake fixup * Comment cleanup * Fix up astypes * Py35 compat * 32 bit compat * PY35 compat * lint fixup * Revert Py35 compat * 32 bit compat restriction * PY35 columns orient sorting * Added missing import * More Py35 compat * Final Py35 compat (hopefully) * Final Py35 compat (hopefully) redux * Windows int fix * Invoke func * 32 bit compat fix * more 32 bit compat * Excepted split from int dtype check * Removed windows compat * Windows test compat * Fixed conftest docstring * Added TODO * Reverted changes to test_frame_from_json_to_json * Removed unused import * Added comment for nanosecond -> ms conversion * Removed duplicate StringIO usage * Used more standard approach for various expected outputs * removed numeric underscores
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Parametrized non unique column test * Parametrized non-unique index tests * Removed skip for values test * Blackify * Parametrized doubled_encoded_labels test * Parametrized 'biggie' test case * Parametrized basic test * simplified test names * int case * Parametrized categorical case * Parametrized empty test case * parametrized ts data * Parametrized mixed case * Removed unnecessary test * Blackify * moved position of dtype parametrization * Parametrized bad_data_raises test * broke off infinity test * parametrized precision test * parametrized infer words * Renamed df_orient to just orient for reuse * parametrized basic series test * Added default orient test * Parametrized empty series test * Parametrized series timeseries test * parametrized series numeric case * Removed unnecessary series roundtrip test * Parametrized date unit test * Parametrized utc test * parametrized ts_range_utc test * Removed py2 compat code * blackify * Parametrized infinity test * parametrized missing data test * Blackify * flake fixup * Comment cleanup * Fix up astypes * Py35 compat * 32 bit compat * PY35 compat * lint fixup * Revert Py35 compat * 32 bit compat restriction * PY35 columns orient sorting * Added missing import * More Py35 compat * Final Py35 compat (hopefully) * Final Py35 compat (hopefully) redux * Windows int fix * Invoke func * 32 bit compat fix * more 32 bit compat * Excepted split from int dtype check * Removed windows compat * Windows test compat * Fixed conftest docstring * Added TODO * Reverted changes to test_frame_from_json_to_json * Removed unused import * Added comment for nanosecond -> ms conversion * Removed duplicate StringIO usage * Used more standard approach for various expected outputs * removed numeric underscores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lot more to be done here but split these up as some of the large functions are difficult to highlight failures while working on extension module. Improved coverage and identified some inconsistencies in process (marked with TODOs) which can be tackled as follow ups