BUG: Fix groupby quantile segfault #27826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate that q is between 0 and 1. Closes pandas-dev#27470
jbrockmendel
reviewed
Aug 8, 2019
pandas/_libs/groupby.pyx
Outdated
| @@ -719,6 +719,11 @@ def group_quantile(ndarray[float64_t] out, | |||
| ndarray[int64_t] counts, non_na_counts, sort_arr | |||
|
|
|||
| assert values.shape[0] == N | |||
|
|
|||
| if q < 0 or q > 1: | |||
There was a problem hiding this comment.
can this be not 0 <= q <= 1
There was a problem hiding this comment.
Seems like it works with parens.
|
LGTM |
jbrockmendel
approved these changes
Aug 9, 2019
|
Thanks @TomAugspurger |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
* BUG: Fix groupby quantile segfault Validate that q is between 0 and 1. Closes pandas-dev#27470 * prettier
|
Going through the 0.25.3 release the test for this showed up in the diff while cherry-picking. On a second review I don't think this was fully back ported (?). I see the whatsnew note but not the test or the changes to groupby.pyx Unless I am overlooking something should I pick this up for the 0.25.3 release as well? |
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 31, 2019
* BUG: Fix groupby quantile segfault Validate that q is between 0 and 1. Closes pandas-dev#27470 * prettier
Merged
jreback
pushed a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that q is between 0 and 1.
Closes #27470