Skip to content

TST: skip test if running non-installed #27810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

jbrockmendel
Copy link
Member

If running the tests without the branch installed, this test fails. Skip it instead.

@@ -46,14 +46,18 @@ def test_backend_is_correct(monkeypatch):

@td.skip_if_no_mpl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesn't this work in this case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is running the tests from a non-virtualenv-like setup. So matplotlib is installed, but the pandas being tested is not in site-packages

@jreback jreback added Testing pandas testing functions or related to the test suite Visualization plotting labels Aug 8, 2019
@jreback jreback added this to the 1.0 milestone Aug 13, 2019
@jreback jreback merged commit d187d90 into pandas-dev:master Aug 13, 2019
@jreback
Copy link
Contributor

jreback commented Aug 13, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the localdev branch August 13, 2019 13:57
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants