BUG: fix+test op(NaT, ndarray), also simplify #27807
Conversation
pandas/_libs/tslibs/nattype.pyx
Outdated
| @@ -103,61 +106,102 @@ cdef class _NaT(datetime): | |||
| if ndim == -1: | |||
| return _nat_scalar_rules[op] | |||
|
|
|||
| if util.is_array(other): | |||
There was a problem hiding this comment.
can you make these if/elif/else
| # TODO: the integer behavior is deprecated, remove it | ||
| return c_NaT | ||
|
|
||
| elif util.is_array(other): |
There was a problem hiding this comment.
this is specifically for ndarray, so there cant be a tz
|
@jreback gentle ping; a few open PRs are blockers for test consolidation etc |
|
will try over weekend |
| ("datetime64[ns]", roperator.radd, "datetime64[ns]"), | ||
| ("datetime64[ns]", operator.sub, "timedelta64[ns]"), | ||
| ("datetime64[ns]", roperator.rsub, "timedelta64[ns]"), | ||
| ("timedelta64[ns]", operator.add, "datetime64[ns]"), |
There was a problem hiding this comment.
shouldn't these last for yield timedelta64[ns]?
There was a problem hiding this comment.
No.
dt64, radd --> dt64 + Nat --> only valid if NaT is treated as td64 --> dt64
dt64, sub --> NaT - dt64 --> only valid if NaT is treated as dt64 --> td64
dt64, rsub --> dt64 - NaT --> valid either way, default to treat as dt64 --> td64
td64, add --> NaT + td64 --> valid either way, defalt to treat as dt64 --> dt64
There was a problem hiding this comment.
ok, yeah these rules are ok, but if you can put them down somewhere explicity in the code
No description provided.