[WIP] Improve CI/CD pipeline performance #27804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, how big is the perf difference? |
It is WIP. WIll know once I make some progress. |
WillAyd
reviewed
Aug 23, 2019
| @@ -59,7 +59,7 @@ New features | |||
|
|
|||
| .. ipython:: python | |||
|
|
|||
| df = DataFrame(np.random.randn(5, 3), columns = ['A','B','C']) | |||
| df = pd.DataFrame(np.random.randn(5, 3), columns = ['A','B','C']) | |||
There was a problem hiding this comment.
Can you revert changes to this file?
There was a problem hiding this comment.
The doc build fails due to an import error
|
does this change perf? can you merge master as well |
|
@bhavaniravi if you want to continue on this, pls merge master and post a comparison of before / after. |
|
I think this is stale or not really giving the results we are after, so closing. @bhavaniravi if you disagree ping and can reopen for sure Thanks as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff