BUG: Fix windowing over read-only arrays #27767
Merged
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#27736, which touches these files, is scheduled for 1.0. I'd prefer to see this in 0.25.1. 😁 |
jbrockmendel
reviewed
Aug 6, 2019
pandas/core/window.py
Outdated
| # Convert inf to nan for C funcs | ||
| inf = np.isinf(values) | ||
| if inf.any(): | ||
| values = values.copy() # GH-27766, Don't write into user's data |
There was a problem hiding this comment.
comment on previous line.
is the issue that we dont want to overwrite user's data, or that the user might pass read-only array?
There was a problem hiding this comment.
Mmm, actually yeah, it's the first.
WillAyd
requested changes
Aug 6, 2019
|
thanks @kernc very nice putting up a bug report AND a PR! |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 6, 2019
3 tasks
gfyoung
pushed a commit
that referenced
this pull request
Aug 6, 2019
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff