Skip to content

CLN: deprivatize names in pd.core.common #27741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2019

Conversation

topper-123
Copy link
Contributor

Some clean-up, as these functions don't need to start with a "_".

@topper-123 topper-123 changed the title CLN: deprivative func names in pd.core.common CLN: deprivatize names in pd.core.common Aug 4, 2019
@jbrockmendel
Copy link
Member

+1 on all of this.

Do are the any_not_none and similar still needed? do they perhaps predate the built-in equivalents? I haven't timed it, but would expect them to be less performant than any(comphrension)

@topper-123
Copy link
Contributor Author

topper-123 commented Aug 4, 2019

any and all are quite old, from python2.5, if I remember correctly, so these funcs were not added for compat reasons.

I like having these functions (a bit less repetitive than spelling them out), thought it's not a strong preference either way, as they're not used all that much.

@topper-123
Copy link
Contributor Author

topper-123 commented Aug 4, 2019

I've made a small update where any/all is used instead of a for loop; I think this is more readable.

@jreback jreback added this to the 1.0 milestone Aug 4, 2019
@jreback
Copy link
Contributor

jreback commented Aug 4, 2019

lgtm. merge on green.

@topper-123 topper-123 merged commit 1944ab8 into pandas-dev:master Aug 4, 2019
@topper-123 topper-123 deleted the deprivatize_com_names branch August 4, 2019 21:26
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
* deprivative funcs in pd.core.common

* simplify all/any funcs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants