Skip to content

BUG: Fix NaT +/- DTA/TDA #27740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2019
Merged

BUG: Fix NaT +/- DTA/TDA #27740

merged 2 commits into from
Aug 4, 2019

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

After this bugfix, we can change all existing uses of dispatch_to_index_op in core.ops.__init__ to use dispatch_to_extension_op. Once we do that, we can collapse ~50 lines of typechecking-dispatching code to all use dispatch_to_extension_op

@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Timedelta Timedelta data type labels Aug 4, 2019
@jreback
Copy link
Contributor

jreback commented Aug 4, 2019

does this affect anything user facing?

@jbrockmendel
Copy link
Member Author

does this affect anything user facing?

No.

@jreback jreback added this to the 1.0 milestone Aug 4, 2019
@jreback
Copy link
Contributor

jreback commented Aug 4, 2019

ping on green

@jbrockmendel
Copy link
Member Author

Ping

@jreback jreback merged commit d330416 into pandas-dev:master Aug 4, 2019
@jbrockmendel jbrockmendel deleted the flops4 branch August 4, 2019 23:08
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants