Skip to content

STYLE: Add flake8-comprehensions to pre-commit configuration #27725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2019
Merged

STYLE: Add flake8-comprehensions to pre-commit configuration #27725

merged 1 commit into from
Aug 4, 2019

Conversation

jschendel
Copy link
Member

Running pre-commit with this change catches the error described in the issue.

@jschendel jschendel added the Code Style Code style, linting, code_checks label Aug 2, 2019
@jschendel jschendel added this to the 1.0 milestone Aug 2, 2019
@jreback jreback merged commit b6a8aee into pandas-dev:master Aug 4, 2019
@jreback
Copy link
Contributor

jreback commented Aug 4, 2019

thanks @jschendel

@jschendel jschendel deleted the pre-commit-comprehensions branch August 5, 2019 18:39
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
@jschendel @quintusdias
Add flake8-comprehensions to pre-commit configuration (pandas-dev#27725)
e5247cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

STYLE: pre-commit does not use flake8-comprehensions plugin
2 participants
@jschendel @jreback