REF/CLN: maybe_downcast_to_dtype #27714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Aug 2, 2019
pandas/core/dtypes/cast.py
Outdated
| result = to_datetime(result).tz_localize("utc") | ||
| result = result.tz_convert(dtype.tz) | ||
|
|
||
| elif dtype.type == Period: |
There was a problem hiding this comment.
how about isintance instead
There was a problem hiding this comment.
actually i think the == should be is, will update
| # earlier | ||
| result = np.array(result) | ||
|
|
||
| def trans(x): |
There was a problem hiding this comment.
rather than doing this, I would pass in a callable directly
There was a problem hiding this comment.
that gives a lot more degrees of freedom to the caller, I'd rather it just be a bool kwarg until/unless we need something more
| return result | ||
|
|
||
|
|
||
| def maybe_downcast_numeric(result, dtype, do_round: bool = False): |
There was a problem hiding this comment.
this is very similar to to_numeric; would plan as a followup to move to_numeric logic here and call this.
jreback
approved these changes
Aug 4, 2019
|
thanks, this is pretty dense code, good to simplify a bit. |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out a numeric-only maybe_downcast_to_dtype_numeric from maybe_downcast_to_dtype. Avoid a giant try/except by checking the correct things up front.
The non-numeric portion of maybe_downcast_to_dtype casts to datetime64, datetime64tz, or PeriodArray. Following #27683 the next step in cleaning up internals is going to be getting rid of _try_cast_result, which will involve replacing a usage of maybe_cast_to_dtype with the less-broadly-scoped maybe_cast_to_dtype_numeric.