CLN: rename reduce-->do_reduce #27706
Conversation
pandas/core/arrays/datetimelike.py
Outdated
| nonexistent : 'shift_forward', 'shift_backward', 'NaT', timedelta, \ | ||
| default 'raise' | ||
| nonexistent : 'shift_forward', 'shift_backward', 'NaT', timedelta, | ||
| default 'raise' |
There was a problem hiding this comment.
this is for proper rendering with numpydoc
| @@ -328,7 +328,6 @@ class DatetimeArray(dtl.DatetimeLikeArrayMixin, dtl.TimelikeOps, dtl.DatelikeOps | |||
| # ----------------------------------------------------------------- | |||
| # Constructors | |||
|
|
|||
| _attributes = ["freq", "tz"] | |||
There was a problem hiding this comment.
Why are you removing those attributes? (I suppose they are thus not used) It's a left-over from when it shared code with the Index?
There was a problem hiding this comment.
exactly, leftover from the inheritance days
pandas/_libs/reduction.pyx
Outdated
| @@ -628,7 +628,7 @@ cdef class BlockSlider: | |||
| arr.shape[1] = 0 | |||
|
|
|||
|
|
|||
| def reduce(arr, f, axis=0, dummy=None, labels=None): | |||
| def do_reduce(arr, f, axis=0, dummy=None, labels=None): | |||
There was a problem hiding this comment.
I don't particular like this name, we don't have anywhere we call things do_*, how about
compute_reduction / apply_reduce
There was a problem hiding this comment.
(and its such an easy change to make because I can grep for it!)
need this too |
|
The Besides, that seems like to defeat Brock's purpose to be able to search for a specific function (and thus not having multiple functions or methods with the same name that do a different thing) |
|
We have _reduce defined in a bunch of places, renaming it should be a separate discussion |
|
can you rebase |
|
rebased+green |
|
Thanks! |
The current name makes it difficult to grep for.
Assorted cleanups; added type annotations in a few places.