-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: grouby(axis=1) cannot select column names #27700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @charlesdong1991! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-02 07:54:46 UTC |
doc/source/whatsnew/v1.0.0.rst
Outdated
@@ -166,6 +166,7 @@ Groupby/resample/rolling | |||
|
|||
- | |||
- | |||
- Bug in :meth:`groupby` does not offer implicit selection by column names when ``axis`` set to 1 (:issue:`27614) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be DataFrame.groupby`
"does not offer" to "not offering"
"axis set to 1" to "axis=1
"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure what "implicit selection by column name" means here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure what "implicit selection by column name" means here.
ahh, my bad, i basically just copied and pasted the issue title, will change! @TomAugspurger thanks for your quick reply!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looking PR! Can you add a test case for a multi index column as well?
Codecov Report
@@ Coverage Diff @@
## master #27700 +/- ##
===========================================
- Coverage 93% 42.49% -50.52%
===========================================
Files 182 182
Lines 50195 50195
===========================================
- Hits 46686 21328 -25358
- Misses 3509 28867 +25358
Continue to review full report at Codecov.
|
@WillAyd @TomAugspurger I added tests for MI columns, and seems work well and pass all tests! Feel free to take a look again! |
thanks @charlesdong1991 |
thanks for merge! |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff