Skip to content

PERF: Improve performance of cut with IntervalIndex bins #27669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

jschendel
Copy link
Member

ASV output:

       before           after         ratio
     [143bc34a]       [d531e7b0]
     <master>         <perf-cut-ii>
-            198M             122M     0.62  reshape.Cut.peakmem_cut_interval(1000)
-            197M             122M     0.62  reshape.Cut.peakmem_cut_interval(4)
-            197M             122M     0.62  reshape.Cut.peakmem_cut_interval(10)
-      2.11±0.02s          910±2ms     0.43  reshape.Cut.time_cut_interval(1000)
-      1.95±0.01s          761±2ms     0.39  reshape.Cut.time_cut_interval(4)
-      1.95±0.03s         763±10ms     0.39  reshape.Cut.time_cut_interval(10)

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

@jschendel jschendel added Performance Memory or execution speed performance Interval Interval data type labels Jul 31, 2019
@jschendel jschendel added this to the 1.0 milestone Jul 31, 2019
@jreback jreback merged commit eb6fd31 into pandas-dev:master Jul 31, 2019
@jreback
Copy link
Contributor

jreback commented Jul 31, 2019

very nice @jschendel

@jschendel jschendel deleted the perf-cut-ii branch July 31, 2019 13:32
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERF: Avoid materializing entire IntervalIndex when using cut
2 participants