Skip to content

DOC: add anonymizeIp for Google analytics in docs #27662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

jorisvandenbossche
Copy link
Member

Using a more recent snippet (following their current docs), and adding anonymization of the IP (according to their docs, this should only "slightly reduce the accuracy of geolocation").

If we do this, should do the same for main website as well.

@jreback jreback added the Docs label Jul 31, 2019
@jreback jreback added this to the 1.0 milestone Jul 31, 2019
@jreback
Copy link
Contributor

jreback commented Jul 31, 2019

lgtm. if anyone @pandas-dev/pandas-core can give this a look see.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No preference on anonymizing ips. I don't know much of the topic, and doesn't seem so very relevant for us, but happy to do it if you think it's good.

Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback merged commit e1b89c8 into pandas-dev:master Aug 1, 2019
@jreback
Copy link
Contributor

jreback commented Aug 1, 2019

thanks @jorisvandenbossche

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants