BUG: Fix dir(interval_index) #27653
BUG: Fix dir(interval_index) #27653
Conversation
jorisvandenbossche
changed the title
jorisvandenbossche
added
the
Regression
There was a problem hiding this comment.
I think the proper fix is to infer_dtype for letting it handle EAs correctly (#23553), but fine with this as a stop-gap for 0.25.1
Yah, the fix I'm working on locally makes infer_dtype handle interval correctly. Getting all EAs right is out of scope. |
| inferred_dtype = lib.infer_dtype(values, skipna=True) | ||
| try: | ||
| inferred_dtype = lib.infer_dtype(values, skipna=True) | ||
| except ValueError: |
There was a problem hiding this comment.
infer_dtype should never raise
There was a problem hiding this comment.
lib.pyx L1207 specifically raises ValueError
There was a problem hiding this comment.
ok, can you make an issue to fix the doc-string in infer_dtype. is possible to handle this inside infer_dtype rather than raise? or is this meant as a tactical fix?
There was a problem hiding this comment.
is possible to handle this inside infer_dtype rather than raise? or is this meant as a tactical fix?
the interval case is fixed by this PR inside infer_dtype, so catching the error here is just a dir-should-never-raise thing. the more general infer_dtype fixes are part of a larger push to recognize EADtypes correctly, yah
|
thanks @jbrockmendel |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff