BUG: raise when wrong level name is passed to "unstack" #27631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobaz
force-pushed
the
unstack_wrong_label_18303
branch
from
dccd0b3 to
20add9f
Compare
Codecov Report
@@ Coverage Diff @@
## master #27631 +/- ##
===========================================
- Coverage 93.02% 42.41% -50.61%
===========================================
Files 182 182
Lines 50257 50259 +2
===========================================
- Hits 46750 21316 -25434
- Misses 3507 28943 +25436
Continue to review full report at Codecov.
|
toobaz
force-pushed
the
unstack_wrong_label_18303
branch
from
20add9f to
3a4a241
Compare
TomAugspurger
approved these changes
Jul 29, 2019
doc/source/whatsnew/v0.25.1.rst
Outdated
| @@ -128,7 +128,7 @@ Groupby/resample/rolling | |||
| Reshaping | |||
| ^^^^^^^^^ | |||
|
|
|||
| - | |||
| - A ``KeyError`` is now raised if ``.unstack()`` is called on a flat :class:`Index` passing a name which is not the correct one (:issue:`18303`) | |||
There was a problem hiding this comment.
"is called on a Series or DataFrame with a flat".
There was a problem hiding this comment.
Seems this affects both stack & unstack?
There was a problem hiding this comment.
"is called on a Series or DataFrame with a flat".
Fixed, thanks
There was a problem hiding this comment.
Seems this affects both stack & unstack?
I added tests for both, but stack was already raising the error.
toobaz
force-pushed
the
unstack_wrong_label_18303
branch
from
3a4a241 to
40d19a0
Compare
jreback
added
Bug
MultiIndex
Reshaping
jreback
added
Error Reporting
jreback
approved these changes
Jul 29, 2019
|
thanks @toobaz |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 29, 2019
…sed to "unstack"
jreback
pushed a commit
that referenced
this pull request
Jul 30, 2019
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffNotice that I profited to make the error message a bit more understandable.