-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Remove Encoding of values in char** For Labels #27618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
648d2b5
with segfaults
WillAyd 37226d7
Merge remote-tracking branch 'upstream/master' into remove-buf-writes
WillAyd e890578
Works save datetimes
WillAyd 24a585a
Less failures, still not correct dt support
WillAyd 42cc1ec
Removed encoder attributes in encodeLabels
WillAyd 7385fd8
Added docstring
WillAyd 4aca787
whitespace cleanup
WillAyd bc5e69a
Removed unused headers
WillAyd d53527f
Moved macro back to vendor c file
WillAyd eefadfa
Merge remote-tracking branch 'upstream/master' into remove-buf-writes
WillAyd 7b2af9f
Merge remote-tracking branch 'upstream/master' into remove-buf-writes
WillAyd 2e25bef
Working TS conversions
WillAyd 0820f57
Parametrized test
WillAyd 185aa61
Fixed epoch precision issue for labels
WillAyd 221e43d
Parametrized failing test
WillAyd 18d28c8
Parametrized frame test
WillAyd 7a5fc9c
Removed UTC cast for index
WillAyd ad06e9c
Merge remote-tracking branch 'upstream/master' into remove-buf-writes
WillAyd 3e22820
blackify
WillAyd 2389a33
Added test for timedelta
WillAyd 104d2f2
Added fix for timedelta as label
WillAyd dbdaed1
Blackify
WillAyd 3ed7979
Comment cleanup and error handling
WillAyd 01ae178
Added test for tuples
WillAyd 0372794
Whatsnew
WillAyd e15bede
Warnings fixup
WillAyd d698255
Simplified object construction
WillAyd d453ed0
Macro for int64 copying
WillAyd 5ab7ecf
Removed unnecessary padding in sprintf
WillAyd 8ea895e
Merge remote-tracking branch 'upstream/master' into remove-buf-writes
WillAyd 439b695
whitespace fixup
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it matter that this is moved from the .h file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is intentional and matches the ujson source. It essentially reverts part of #17857