Skip to content

DOC:Update python version support info #27580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2019
Merged

DOC:Update python version support info #27580

merged 3 commits into from
Aug 1, 2019

Conversation

sameshl
Copy link
Contributor

@sameshl sameshl commented Jul 25, 2019

Updated the python version support info.
Added minimum version for Python 3.5 is 3.5.3 and removed python 2.7 support info.

closes #27558

Updated the python version support info.
Added minimum version for Python 3.5 is 3.5.3 and removed python 2.7 support info.

closes #27558
@WillAyd
Copy link
Member

WillAyd commented Jul 25, 2019

Looks good to me. Is this the last area that needed to be fixed?

@WillAyd WillAyd added the Docs label Jul 25, 2019
@TomAugspurger
Copy link
Contributor

We can probably drop the "Plan for dropping Python 2.7" starting on line 20.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jul 25, 2019

L932 in user_guide/io.rst also refers to 2.7

932:   an ordering on their keys. On Python 2.7+ you may use `collections.OrderedDict`

@sameshl
Copy link
Contributor Author

sameshl commented Jul 26, 2019

@TomAugspurger so I just have to remove the part on "Plan for dropping Python 2.7" starting on line 20?

@jreback
Copy link
Contributor

jreback commented Jul 26, 2019

@TomAugspurger so I just have to remove the part on "Plan for dropping Python 2.7" starting on line 20?

yes

@jreback jreback modified the milestones: 1.0, 0.25.1 Jul 26, 2019
@jreback
Copy link
Contributor

jreback commented Jul 27, 2019

looks ok, the docs checks are failing, click thru to see. ping on green.

@sameshl
Copy link
Contributor Author

sameshl commented Jul 28, 2019

@jreback I understand the problem. The internal ref, install.dropping-27, which was pointing to the section which I just removed on "Droping Python 2.7" is now broken. There are few instances of this ref in the doc/source/whatsnew/ files. Should I remove the reference in those files then ?

@jreback
Copy link
Contributor

jreback commented Jul 28, 2019

what you need to do is replace the refs with actual http links to the 0.24.2 docs

https://pandas.pydata.org/pandas-docs/version/0.24/install.html#install-dropping-27

@TomAugspurger TomAugspurger modified the milestones: 0.25.1, 1.0 Aug 1, 2019
@TomAugspurger
Copy link
Contributor

Thanks @sameshl, this looks good.

@jreback for doc-only PRs that aren't specific to 0.25, I think we shouldn't backport. What do you think?

@jreback
Copy link
Contributor

jreback commented Aug 1, 2019

@TomAugspurger agree generally on this point
however we want this one to update the 0.25.x docs as it’s particularly relevant

@jreback jreback modified the milestones: 1.0, 0.25.1 Aug 1, 2019
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 1, 2019 via email

@jreback jreback merged commit 52362bf into pandas-dev:master Aug 1, 2019
@jreback
Copy link
Contributor

jreback commented Aug 1, 2019

thanks @sameshl

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 1, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 0.25.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 52362bf220d902c87850dde473c1cebc048ee744
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #27580: DOC:Update python version support info'
  1. Push to a named branch :
git push YOURFORK 0.25.x:auto-backport-of-pr-27580-on-0.25.x
  1. Create a PR against branch 0.25.x, I would have named this PR:

"Backport PR #27580 on branch 0.25.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

jreback pushed a commit to jreback/pandas that referenced this pull request Aug 1, 2019
jreback added a commit that referenced this pull request Aug 1, 2019
@sameshl sameshl deleted the doc_version_support branch August 1, 2019 14:22
@sameshl
Copy link
Contributor Author

sameshl commented Aug 1, 2019

Thanks @jreback and @TomAugspurger!

quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Unable to import pandas on python 3.5.2
4 participants