-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC:Update python version support info #27580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the python version support info. Added minimum version for Python 3.5 is 3.5.3 and removed python 2.7 support info. closes #27558
Looks good to me. Is this the last area that needed to be fixed? |
We can probably drop the "Plan for dropping Python 2.7" starting on line 20. |
L932 in user_guide/io.rst also refers to 2.7
|
@TomAugspurger so I just have to remove the part on "Plan for dropping Python 2.7" starting on line 20? |
yes |
looks ok, the docs checks are failing, click thru to see. ping on green. |
@jreback I understand the problem. The internal ref, |
what you need to do is replace the refs with actual http links to the 0.24.2 docs https://pandas.pydata.org/pandas-docs/version/0.24/install.html#install-dropping-27 |
…2.7 to the actual http link. `install.dropping-27` --> `https://pandas.pydata.org/pandas-docs/version/0.24/install.html#install-dropping-27`
@TomAugspurger agree generally on this point |
SGTM.
…On Thu, Aug 1, 2019 at 6:44 AM Jeff Reback ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> agree generally on this
point
however we want this one to update the 0.25.x docs as it’s particularly
relevant
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27580?email_source=notifications&email_token=AAKAOIVYR74DPSTNMYRYBPLQCLEABA5CNFSM4IGXGTD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3KJPDA#issuecomment-517248908>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOISVMAGMW4EFRFQ4EE3QCLEABANCNFSM4IGXGTDQ>
.
|
thanks @sameshl |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Thanks @jreback and @TomAugspurger! |
Updated the python version support info.
Added minimum version for Python 3.5 is 3.5.3 and removed python 2.7 support info.
closes #27558