CLN: remove block._coerce_values #27567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#27445 is a subset of this |
jreback
requested changes
Jul 26, 2019
| @@ -51,15 +51,15 @@ def test_indexing_with_datetime_tz(self): | |||
| # indexing | |||
| result = df.iloc[1] | |||
| expected = Series( | |||
| [Timestamp("2013-01-02 00:00:00-0500", tz="US/Eastern"), np.nan, np.nan], | |||
There was a problem hiding this comment.
does this not work now (the existing code)?
There was a problem hiding this comment.
I think the test is incorrect, and tm.assert_series_equal is getting it wrong.
now = pd.Timestamp.now("US/Eastern")
left = pd.Series([now, pd.NaT, pd.NaT], dtype=object)
right = pd.Series([now, np.nan, np.nan], dtype=object)
tm.assert_series_equal(left, right)
There was a problem hiding this comment.
Will open an issue for assert_series_equal
| @@ -2512,22 +2468,22 @@ def _try_coerce_args(self, other): | |||
| def _try_coerce_result(self, result): | |||
| """ reverse of try_coerce_args """ | |||
| if isinstance(result, np.ndarray): | |||
| if result.dtype.kind in ["i", "f"]: | |||
| result = result.astype("M8[ns]") | |||
| if result.ndim == 2: | |||
There was a problem hiding this comment.
can you add a comment or 2 here
| @@ -1547,14 +1530,13 @@ def quantile(self, qs, interpolation="linear", axis=0): | |||
| # We need to operate on i8 values for datetimetz | |||
| # but `Block.get_values()` returns an ndarray of objects | |||
| # right now. We need an API for "values to do numeric-like ops on" | |||
| values = self.values.asi8 | |||
| values = self.values.view("M8[ns]") | |||
There was a problem hiding this comment.
we should probably remove .asi8 on Index as I agree its sligthly confusing (I don't think we need deprecation)
jreback
approved these changes
Jul 26, 2019
|
thanks |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viable now that we stopped coercing timedelta and datetime to i8
I'd like to clean up DatetimeTZBlock._try_coerce_result before getting this in. Part of that means pushing the handling down to the function being wrapped