BUG: Fix interpolate ValueError for datetime64_tz index #27549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 23, 2019
doc/source/whatsnew/v0.25.1.rst
Outdated
| @@ -56,7 +56,7 @@ Timezones | |||
|
|
|||
| Numeric | |||
| ^^^^^^^ | |||
| - | |||
| - Bug in :meth:`interpolate` when using a timezone aware index (:issue:`27548`) | |||
There was a problem hiding this comment.
... when using a timezone aware :class:`DatetimeIndex` ...
jreback
added
Bug
Numeric Operations
jreback
reviewed
Jul 23, 2019
doc/source/whatsnew/v0.25.1.rst
Outdated
| @@ -56,7 +56,7 @@ Timezones | |||
|
|
|||
| Numeric | |||
| ^^^^^^^ | |||
| - | |||
| - Bug in :meth:`interpolate` when using a timezone aware :class:`DatetimeIndex` (:issue:`27548`) | |||
There was a problem hiding this comment.
this won't render, you want :meth:`Series.interpolate`
|
looks ok, ping when changed & green. |
jreback
requested changes
Jul 23, 2019
| @@ -1521,12 +1521,23 @@ def test_interp_nonmono_raise(self): | |||
| s.interpolate(method="krogh") | |||
|
|
|||
| @td.skip_if_no_scipy | |||
| def test_interp_datetime64(self): | |||
| @pytest.mark.parametrize("method", ["nearest", "pad"]) | |||
There was a problem hiding this comment.
you can parametrize on tz_naive_fixture here (and just remove the bottom test); this includes None and a bunch of timezones.
|
@jreback I've updated to use the tz_naive_fixture and checks are green |
mroeschke
approved these changes
Jul 23, 2019
jreback
approved these changes
Jul 24, 2019
|
thanks @alorenzo175 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 24, 2019
…etime64_tz index
jreback
pushed a commit
that referenced
this pull request
Jul 24, 2019
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff