-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI debug #27542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI debug #27542
Conversation
Different error this time right? |
We did have a timeout earlier, but I think it looked a bit different than the last one. I restarted the build. |
ci/deps/travis-36-cov.yaml
Outdated
@@ -40,7 +40,7 @@ dependencies: | |||
- xlwt | |||
# universal | |||
- pytest>=4.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need pytest<5.0.0; I thought we had added this (its on all the other 3.6 builds)
I don't know if directly relevant here since current build complies but there is a note for pytest >5.0.0 that if used with pytest-xdist that should at least be 1.29.0 or later in the changeling: https://docs.pytest.org/en/latest/changelog.html#features Might be related to some of the issues (this one seems suspiciously related to the one we saw last week on Azure) |
Though it does look like the issue Jeff has in the OP of #27541 has pytest-xdist 1.28.0 and pytest 5.0.1 so issue might just boil down to that |
Ignore comments above - I should have looked at diff. But yea this seems like the right change |
Huh that sounds extremely relevant. In a meeting now, but will update everything to be pytest >5, pytest-xdist >=1.2.9 (unless someone beats me). |
Current build here meets those specs but just failed again so I think it's still something else |
Trying to pin that build to |
Well this one failed with out of memory errors when we tried to open a subprocess
|
Yea was about to comment. I have the feeling this might be the root issue and the original issues we saw were problems with pytest / pytest-xdist compat and actually reporting out the error. |
Is it this same test failing repeatedly? We could wrap the subprocess call in something like:
|
We do seem to have less disk space, which indicates we may be running on a smaller VM. From https://travis-ci.org/pandas-dev/pandas/jobs/561486224 (3 days ago)
And from today
I'm not sure if we print our RAM in the logs. |
@@ -1,4 +1,3 @@ | |||
sudo: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shot in the dark but looks like this was deprecated
https://docs.travis-ci.com/user/reference/trusty/#container-based-infrastructure
FYI, we may want to keep an eye on https://travis-ci.community/t/builds-often-fail-because-of-lack-of-resources-memory-cpu/4331 and travis-ci/worker#604. Seems like the worker images are being given less resources. For now, we might lighten the load on that build by removing some optional deps. I'd propose removing matplotlib for a start. |
Another OOM crash. I'm removing matplotlib from those two environments. |
OK, that passed. Any objections to merging as is, and cleaning up the CI files in a followup PR? I suspect the pytest & pytest-xdist pins are no longer necessary, but it'd be good to get other PRs going again. |
Ok by me |
hmm I suspect we need to backport this to 0.25.1 |
* pytest-xdist? * pytest 4.x * Remove deprecated container base * remove matplotlib from travis workers
Closes #27541