Make a fastpath conditional on data is None
#27475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the pre-existing comment in the code: this is a fastpath for the case `data is None`. Better include an if-statement to make sure this condition actually holds. When this if-statement is not present, failure occurs at a later point in the code when an empty index is used, because that later code expects data to be array-like, but we convert to a scalar here. fix #26469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the pre-existing comment in the code: this is a fastpath for the
case
data is None. Better include an if-statement to make sure thiscondition actually holds.
When this if-statement is not present, failure occurs at a later point
in the code when an empty index is used, because that later code expects data
to be array-like, but we convert to a scalar here.
====
NOTE: this is a "shoot from the hip" (completely untested) PR as it stands.
I hope it can contribute towards a solution nonetheless, but it needs at least
tests
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff