-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
add some type annotations io/formats/format.py #27418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WillAyd
merged 17 commits into
pandas-dev:master
from
simonjayhawkins:format-partial-typing-and-refactor
Jul 21, 2019
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c0291fa
add some type annotations and refactor io/formats/format.py
simonjayhawkins 5df8ffa
blackify
simonjayhawkins b73d522
refactor to remove redefinition of variable with incompatible type
simonjayhawkins ce71739
simplify
simonjayhawkins 32d3b29
refactor _get_column_name_list
simonjayhawkins 3cff805
remove NoneType return value from __init__
simonjayhawkins 2c37a0b
use typing.TextIO instead of StringIO
simonjayhawkins a8cf8e1
Merge remote-tracking branch 'upstream/master' into format-partial-ty…
simonjayhawkins db4bfe7
reduce diff
simonjayhawkins 0ac539b
blackify
simonjayhawkins ff47366
Merge remote-tracking branch 'upstream/master' into format-partial-ty…
simonjayhawkins 480c808
remove properties
simonjayhawkins 7dc2af0
remove abcs
simonjayhawkins 035ec58
revert refactor of _chk_truncate
simonjayhawkins a58f1cd
revert other refactorings
simonjayhawkins 66f6069
add type hint to _get_columns_formatted_values was abc
simonjayhawkins dd3c46d
remove Any from Iterable
simonjayhawkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required? Generally we try to avoid cast and I'm surprised MyPy can't narrow the type down here from None.
If it's fully required does making line 238 say
max_rows is not None and ...
get around that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. gives
pandas\io\formats\format.py:249: error: Unsupported operand types for // ("None" and "int")
and there might be risk in implementing this differently anyway?well I would have agreed with you when I started this, but after this PR, I think that adding type annotations should be just that and any refactoring or code cleanup should be deferred to a follow on PR.
Agreed. hence the numerous iterations to try and avoid cast originally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm OK yea seems like a bug / gap with mypy inference then. Can always come back to clean up