-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: get parts of Block.replace out of try/except #27408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e18c342
replace try/except in Block.replace
jbrockmendel 27f4c27
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 4677429
comment
jbrockmendel 6251c58
comment
jbrockmendel d88e5bc
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 3ae3c58
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 21e07ed
remove unreachable
jbrockmendel 8165ed1
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 26adf4b
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 2295ea1
more general can_hold_na catching
jbrockmendel 7073dff
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel d28e300
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes this block different than all others, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the status quo,
raise
re-raises the exception that is caught on 789. But now we don't have that to re-raise, so we need to raise a new exception. Theraise
on 793 is not reached (and should not be reachable)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we instead define an internal exception, say DtypeInvalidException (or better name) which inherits this then for flow control.