TST: add NaN tests for all data types (#12535) #27378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any interest in converting this to a fixture(s)? |
WillAyd
added
Testing
|
@WillAyd yes, I might try to do that, but not right now, though. |
|
OK thanks. This is in real need of it so any contribution there would be greatly appreciated. I think this looks OK otherwise though @jreback |
|
i’ll look soon |
|
@tq0 can you use paramterize here instead; this is getting long and is non-idiomatic. |
|
I'd prefer parametreziation be done separately. The diff here is relatively
easy to understand.
…On Mon, Jul 15, 2019 at 7:23 AM Jeff Reback ***@***.***> wrote:
***@***.**** requested changes on this pull request.
comments
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#27378?email_source=notifications&email_token=AAKAOISL4JI7QXKOKLKNDWDP7RT55A5CNFSM4IC4DRBKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6NID5Y#pullrequestreview-261784055>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIQ5EH2Y6VGFQ2AXQ7LP7RT55ANCNFSM4IC4DRBA>
.
|
jreback
approved these changes
Jul 15, 2019
|
thanks @tq0 if you can follow up with a PR to parameterize would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff