Skip to content

BUG: make parser.pyx method polymorphic for gil/nogil cases #27373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

BUG: make parser.pyx method polymorphic for gil/nogil cases #27373

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2019

Warning: this requires Cython 0.30 (not yet released as of Jul 2019) (the CI currently fails to build)

The next release of Cython 0.30.0 introduced conditional gil acqusition with support for fused types.

This makes a clean solution for #27372 possible, eliminating the cython warning

warning: pandas/_libs/parsers.pyx:1724:34: Casting a GIL-requiring 
function into a nogil function circumvents GIL validation

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is highly unlikely to be looked at until cython is out for a while

@ghost
Copy link
Author

ghost commented Jul 13, 2019

this is highly unlikely to be looked at until cython is out for a while

Of course.

@ghost
Copy link
Author

ghost commented Jul 31, 2019

@jbrockmendel, I'm clearing my desk of pandas PRs. This looks like it would be useful in the future, would you like to grab a local copy and take over or should I just delete?

@jbrockmendel
Copy link
Member

@pilkibun is leaving this on the back-burner until cython 30 is out (plus some time for possible bugfix release)?

@ghost
Copy link
Author

ghost commented Jul 31, 2019

@jbrockmendel moving on to other interests and would like to to leave a clean slate. Best if you pull the branch and push it at your convenience sometime in the future. If you're not interested that's fine too of course.

@ghost
Copy link
Author

ghost commented Jul 31, 2019

Ok, someone will take care of this eventually.

@ghost ghost closed this Jul 31, 2019
@ghost ghost deleted the fix_parser_gil branch July 31, 2019 18:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cython warning about unsafe nogil cast in parsers.pyx
2 participants