-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: make parser.pyx method polymorphic for gil/nogil cases #27373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…morphic higher order function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is highly unlikely to be looked at until cython is out for a while
Of course. |
@jbrockmendel, I'm clearing my desk of pandas PRs. This looks like it would be useful in the future, would you like to grab a local copy and take over or should I just delete? |
@pilkibun is leaving this on the back-burner until cython 30 is out (plus some time for possible bugfix release)? |
@jbrockmendel moving on to other interests and would like to to leave a clean slate. Best if you pull the branch and push it at your convenience sometime in the future. If you're not interested that's fine too of course. |
Ok, someone will take care of this eventually. |
Warning: this requires Cython 0.30 (not yet released as of Jul 2019) (the CI currently fails to build)
The next release of Cython 0.30.0 introduced conditional gil acqusition with support for fused types.
This makes a clean solution for #27372 possible, eliminating the cython warning