BUG: Need 'windows-1252' encoding for locale names.

[timcera]

#24760
#23638
There are some special characters encoded with 'window-1252' in lists
created by 'locale -a'. The two know locales with this problem are
Norwegian 'bokmål', and 'français'.

• closes Pandas Test Scripts always fail tried 0.24.0rc1, 0.23.4, 0.23.3 and 0.23.2 #24760 Already closed but previous resolution was a work-around
• closed pandas 0.23.4 fails unit tests #23638 Already closed without resolution
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[WillAyd]

Is there any chance that using subprocess.run instead of subprocess.check_output helps here at all? We only support >=Py35 so could switch from the older API if it helps simplify

[timcera]

Is there any chance that using subprocess.run instead of subprocess.check_output helps here at all? We only support >=Py35 so could switch from the older API if it helps simplify

Neither subprocess.run nor subprocess.check_output should change or set the output encoding. The encoding should only depend on what locale -a prints. Why 'windows-1252' instead of 'utf-8'? I have no idea.

[WillAyd]

Can you mock out a test for this?

[WillAyd]

Also be sure to run black pandas on your local branch before pushing (that is the current CI failure)

[WillAyd]

@timcera can you add a test and merge master?

[jreback]

this looks ok actually, @timcera can you add a note to 1.0; if you can do a test great, but not a big deal otherwise.

[jbrockmendel]

@timcera can you rebase? I think the CI failure may be unrelated

[jreback]

this is prob ok, can you merge master and add a note to 1.0.0, ping on green.

[timcera]

Have to ask - what does "note to 1.0.0, ping on green" mean?

…

On Sun, Oct 6, 2019 at 7:55 PM Jeff Reback ***@***.***> wrote: this is prob ok, can you merge master and add a note to 1.0.0, ping on green. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27368?email_source=notifications&email_token=AACIRNV26PFREBCT4MGYTPLQNJ3IPA5CNFSM4ICRV4OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOXK7I#issuecomment-538801533>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACIRNXVKDLVQX7FUDQULCTQNJ3IPANCNFSM4ICRV4OA> .

[WillAyd]

Can you add a note to doc/source/whatsnew/v1.0.0.rst describing the change and then notify when CI is green after pushing up the change?

[timcera]

All checks passed.

[jreback]

thanks @timcera