Accept empty dataframes in DataFrame.to_parquet #27341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 11, 2019
| @@ -471,6 +471,10 @@ def test_partition_cols_supported(self, pa, df_full): | |||
| assert len(dataset.partitions.partition_names) == 2 | |||
| assert dataset.partitions.partition_names == set(partition_cols) | |||
|
|
|||
| def test_empty_dataframe(self, pa): | |||
| df = pd.DataFrame() | |||
There was a problem hiding this comment.
can you add the github issue number as a comment
| @@ -566,3 +570,9 @@ def test_error_on_using_partition_cols_and_partition_on(self, fp, df_full): | |||
| partition_on=partition_cols, | |||
| partition_cols=partition_cols, | |||
| ) | |||
|
|
|||
| def test_empty_dataframe(self, fp): | |||
| df = pd.DataFrame() | |||
|
Thanks @jreback. Should this go in the whatsnew for 0.25.0 or 0.25.1? |
you can put in 0.25.0 |
jorisvandenbossche
approved these changes
Jul 11, 2019
jreback
added
the
Compat
jreback
approved these changes
Jul 11, 2019
|
lgtm. @CJStadler ping on green. |
|
It's green @jreback. Thanks! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27339
I wrote two tests because
fastparquetadds a name to the index when it deserializes.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff