ENH: add NDFrame.select_str #27340
Closed
ENH: add NDFrame.select_str #27340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-11 20:38:22 UTC |
topper-123
force-pushed
the
NDFrame.select_str
branch
from
8857c97 to
c243435
Compare
topper-123
force-pushed
the
NDFrame.select_str
branch
2 times, most recently
from
d5830b1 to
e4345ab
Compare
WillAyd
reviewed
Jul 11, 2019
|
|
||
| Parameters | ||
| ---------- | ||
| startswith: str, optional |
There was a problem hiding this comment.
Can we not just boil the signature down to regex?
There was a problem hiding this comment.
Yeah, startswith and endswith are not cardinal points for me, just thought they are often used, so nicer for people who don't want/know how to use regexes.
topper-123
force-pushed
the
NDFrame.select_str
branch
from
e4345ab to
4ed0630
Compare
jreback
requested changes
Jul 11, 2019
| return matcher.search(x) is not None | ||
|
|
||
| mapped = labels.map(f) | ||
| return self.loc(axis=axis)[mapped] |
There was a problem hiding this comment.
so I would instead implement
df.loc(regex=)[....] as an api, which turns the indexers into regexes.
jreback
added
the
Indexing
6 tasks
|
Closing in favor of #27363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdds a method
select_strto supplementselect_dtypes. This PR is intended to be followed by a PR that deprecateNDFrame.filter.I miss the most having a string focused axis-filtering method, and is
NDFrame.filtera bit unfocused and badly named IMO. I think usage of parameteritemsinNDFrame.filtercan just be replaced by recommendingNDFrame.__getitem__and parameterlikeis less useful thanstartswithandendswith(is less precise). So this is not a 100 % replacement forNDFrame.filter, but intends to make something that is more useful (IMO, of course).This is not fully tested and need a whatsnew etc. but I would like to get some response before I go further.