Skip to content

CLN: remove Hypothesis warning during test #27336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from Jul 11, 2019
Merged

CLN: remove Hypothesis warning during test #27336

merged 4 commits into from Jul 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2019

hypothesis\_settings.py:193: HypothesisDeprecationWarning: The timeout setting can 
safely be removed with no effect.

Starting with 4.0.0 released in Jan, the timeout setting does nothing.

https://hypothesis.readthedocs.io/en/latest/settings.html#hypothesis.settings.timeout

    The timeout setting has been deprecated and no longer does anything.

    default value: not_set

    The timeout setting can safely be removed with no effect.

Bump dependency from >=3.8.2 and remove setting.

@WillAyd
Copy link
Member

WillAyd commented Jul 11, 2019

The bump here just suppresses the warning right? Would also want to add a note to min dependencies section in 0.25 whatsnew

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to update any ci/deps where we explicity set the hypothesis versions

@jreback jreback added CI Continuous Integration Testing pandas testing functions or related to the test suite labels Jul 11, 2019
@ghost
Copy link
Author

ghost commented Jul 11, 2019

The bump here just suppresses the warning right?

Yeah, and it seems to be gone from CI. Don't expect any breaking due to upgrade.

you also need to update any ci/deps where we explicity set the hypothesis versions

thanks.

@ghost
Copy link
Author

ghost commented Jul 11, 2019

Turns out hypothesis 4.0.0 dropped python3.5 support. What do you want to do?

@WillAyd
Copy link
Member

WillAyd commented Jul 11, 2019 via email

@ghost
Copy link
Author

ghost commented Jul 11, 2019

Does just removing the timeout without bumping get us to the same place?

For the CI? yeah, in that even without bumping 'hypothesis>=3.58.2' CI installs the current version. a user who hasn't updated deps in 8 months may run into some timeout issues. Sounds ok.

@jreback jreback added this to the 0.25.0 milestone Jul 11, 2019
@jreback
Copy link
Contributor

jreback commented Jul 11, 2019

this is ok, ping on green.

@ghost
Copy link
Author

ghost commented Jul 11, 2019

@jreback green.

@jreback jreback merged commit 5a7a8e1 into pandas-dev:master Jul 11, 2019
@ghost ghost deleted the hypo_timeout branch July 11, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants