-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: remove Hypothesis warning during test #27336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The bump here just suppresses the warning right? Would also want to add a note to min dependencies section in 0.25 whatsnew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to update any ci/deps where we explicity set the hypothesis versions
Yeah, and it seems to be gone from CI. Don't expect any breaking due to upgrade.
thanks. |
Turns out hypothesis 4.0.0 dropped python3.5 support. What do you want to do? |
Does just removing the timeout without bumping get us to the same place?
…Sent from my iPhone
On Jul 11, 2019, at 12:36 PM, pilkibun ***@***.***> wrote:
Turns out hypothesis 4.0.0 dropped python3.5 support. What do you want to do?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
For the CI? yeah, in that even without bumping 'hypothesis>=3.58.2' CI installs the current version. a user who hasn't updated deps in 8 months may run into some timeout issues. Sounds ok. |
this is ok, ping on green. |
@jreback green. |
Starting with 4.0.0 released in Jan, the timeout setting does nothing.
https://hypothesis.readthedocs.io/en/latest/settings.html#hypothesis.settings.timeout
Bump dependency from
>=3.8.2
and remove setting.