BUG: fix+test assigning invalid NAT-like to DTA/TDA/PA #27331
Conversation
jreback
added
the
Missing-data
| expected = type(array)._from_sequence([pd.NaT, array[1], array[2]]) | ||
|
|
||
| casting_nats = { | ||
| TimedeltaArray: [pd.NaT, np.timedelta64("NaT", "ns")], |
There was a problem hiding this comment.
this is too complicated, just provide the expected alongside the values above
| DatetimeArray: [pd.NaT, np.datetime64("NaT", "ns")], | ||
| PeriodArray: [pd.NaT], | ||
| }[type(array)] | ||
| non_casting_nats = { |
There was a problem hiding this comment.
this would be better to parameterize over the non_casting_nats and the casting_nats in a separate test. too much going on here.
| @@ -651,3 +651,38 @@ def test_array_interface(self, period_index): | |||
| result = np.asarray(arr, dtype="S20") | |||
| expected = np.asarray(arr).astype("S20") | |||
| tm.assert_numpy_array_equal(result, expected) | |||
|
|
|||
There was a problem hiding this comment.
are there other setitem tests? put near those
| ], | ||
| ids=lambda x: type(x).__name__, | ||
| ) | ||
| def test_nat_assignment_array(array): |
|
comments addressed i think |
| def test_casting_nat_setitem_array(array, casting_nats): | ||
| expected = type(array)._from_sequence([pd.NaT, array[1], array[2]]) | ||
|
|
||
| for nat in casting_nats: |
There was a problem hiding this comment.
can you make another level of parameterization to make these truly separate tests?
There was a problem hiding this comment.
I don't think so; the casting_nats parameter depends on the array parameter.
I've been looking at pytest extensions that might make this kind of thing possible
| @@ -559,3 +559,27 @@ def remove_na_arraylike(arr): | |||
| return arr[notna(arr)] | |||
| else: | |||
| return arr[notna(lib.values_from_object(arr))] | |||
|
|
|||
|
|
|||
| def is_valid_nat_for_dtype(obj, dtype): | |||
There was a problem hiding this comment.
can you type these(followup ok)
jreback
added
Period
Broken off from #27311 for cleaner scope and to troubleshoot platform-specific failures. Related but orthogonal to #27323.