Skip to content

PERF: Suppress ix warnings benchmarks #27304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2019
Merged

PERF: Suppress ix warnings benchmarks #27304

merged 7 commits into from
Jul 9, 2019

Conversation

leeyspaul
Copy link
Contributor

@leeyspaul leeyspaul commented Jul 9, 2019

TODO: add tests for suppressed warnings.

@leeyspaul leeyspaul changed the title Suppress ix warnings benchmarks PERF: Suppress ix warnings benchmarks Jul 9, 2019
@leeyspaul
Copy link
Contributor Author

@jreback for review. Thank you!

@jorisvandenbossche
Copy link
Member

@leeyspaul I think you are adding the filterwarnings in the wrong place. We don't want to suppress those warnings in general (that's why we put them there, so users see them), but only in the benchmarks. So it is inside the benchmarking code that we would need to add filters.

@leeyspaul
Copy link
Contributor Author

@jorisvandenbossche Ahhh right, thank you for that. I believe I've suppressed the appropriate warnings in the right places this time around! Please take a look when able. :)

@jreback jreback added Deprecate Functionality to remove in pandas Performance Memory or execution speed performance labels Jul 9, 2019
@jreback jreback added this to the 0.25.0 milestone Jul 9, 2019
@jreback jreback merged commit 967bd95 into pandas-dev:master Jul 9, 2019
@jreback
Copy link
Contributor

jreback commented Jul 9, 2019

thanks @leeyspaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERF: benchmarks are hitting .ix & other warnings
3 participants