BUG: appending a Timedelta to Series incorrectly casts to integer #27303
Conversation
jbrockmendel
changed the title
pandas/core/indexing.py
Outdated
| [self.obj._values, new_values] | ||
| ) | ||
| except TypeError: | ||
| as_obj = self.obj.astype(object) |
There was a problem hiding this comment.
Was this hitting the except clause before? Not super familiar with this code but seems like some duplication we could ideally clean up / refactor
There was a problem hiding this comment.
It was not raising in the relevant case, and the np.concatenate would cast the timedelta64 to int64.
seems like some duplication we could ideally clean up / refactor
Yes, this method in particular is in dire need of a refactor. ATM I'm focused on Block._try_coerce_arg and Block._can_hold_element (see other open PRs) and I think/hope once some inconsistencies in those are ironed out, some of the special-casing here may be unnecessary.
| # GH#22717 inserting a Timedelta should _not_ cast to int64 | ||
| ser = pd.Series(["x"]) | ||
| ser["td"] = pd.Timedelta("9 days") | ||
| assert isinstance(ser["td"], pd.Timedelta) |
There was a problem hiding this comment.
Lost previous comment but can you use tm.assert_series_equal here? Also move to a separate test (test_timedelta_assignment_to_object?)
jbrockmendel
changed the title
| @@ -653,6 +653,15 @@ def test_timedelta_assignment(): | |||
| expected.loc[[1, 2, 3]] = pd.Timedelta(np.timedelta64(20, "m")) | |||
| tm.assert_series_equal(s, expected) | |||
|
|
|||
| # GH#22717 inserting a Timedelta should _not_ cast to int64 | |||
There was a problem hiding this comment.
new test pls & parameterize over timedelta & np.timedelta64 as wel
| @@ -653,6 +653,15 @@ def test_timedelta_assignment(): | |||
| expected.loc[[1, 2, 3]] = pd.Timedelta(np.timedelta64(20, "m")) | |||
| tm.assert_series_equal(s, expected) | |||
There was a problem hiding this comment.
should really put this in a test_timedelta.py (and take the existing tests out of test_indexing).
There was a problem hiding this comment.
after the current batch of PRs I'm planning on doing a review of the indexing tests. There are multiple dimensions along which we can sort/parametrize, any of which would be reasonable, but my guess is we are not being consistent about it.
| # GH#22717 inserting a Timedelta should _not_ cast to int64 | ||
| ser = pd.Series(["x"]) | ||
| ser["td"] = pd.Timedelta("9 days") | ||
| assert isinstance(ser["td"], pd.Timedelta) |
There was a problem hiding this comment.
can you compare vs the expected series instead
|
thanks, pls add the comments to list of followups |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff