TST/STYLE: concatenate string literals post black reformatting #27281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Testing
|
do these pass line length? you might need to use parens and split on lines |
should pass black lint rule. is that what you mean? |
|
is the flake rule in setup.cfg updated? to 79 |
simonjayhawkins
commented
Jul 7, 2019
| with pytest.raises( | ||
| AttributeError, | ||
| match="Can only use .str " "accessor with string values.*", | ||
| ): |
There was a problem hiding this comment.
with the black code style applied, I'm now beginning to prefer this layout rather than having the msg= on the previous line.
we currently did this where line length was an issue.
am I missing something? we're using 88 and black ignores that sometimes anyway. |
|
actually we r using the black default which is 88 |
|
thanks @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.