Skip to content

TST/CLN: remove try block from tests/test_strings.py::TestStringMetho… #27277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

TST/CLN: remove try block from tests/test_strings.py::TestStringMetho… #27277

merged 1 commit into from
Jul 8, 2019

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jul 7, 2019 •
edited
Loading

…ds::test_slice

it looks like this was probably added for debugging. This is not necessary with parametrisation.

@simonjayhawkins simonjayhawkins added Clean Testing pandas testing functions or related to the test suite labels Jul 7, 2019
WillAyd
WillAyd approved these changes Jul 7, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback added this to the 0.25.0 milestone Jul 7, 2019
@jreback jreback merged commit b377a78 into pandas-dev:master Jul 8, 2019
@jreback
Copy link
Contributor

jreback commented Jul 8, 2019

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the test_slice branch July 8, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jreback @WillAyd