ENH: Raise ValueError for unsupported Window functions #27275
Conversation
|
@jreback it is ok when directly calling an unsupported function but raised error ( |
|
Please don't merge this as it raises |
AttributeError is raised since it is conflicting with the one when list-like arg is provided. TypeError is catched since it is raised when 'median' is passed as an arg
|
|
pandas/core/base.py
Outdated
| return f(self, *args, **kwargs) | ||
|
|
||
| except (AttributeError, TypeError): | ||
| raise AttributeError( |
There was a problem hiding this comment.
I would pass here, then just use a single raise (line 326)
pandas/core/window.py
Outdated
| @@ -511,6 +511,7 @@ class Window(_Window): | |||
| Set the labels at the center of the window. | |||
| win_type : str, default None | |||
| Provide a window type. If ``None``, all points are evenly weighted. | |||
| Other types are only applicable for `mean` and `sum` functions. | |||
There was a problem hiding this comment.
this should be on .agg so I wouldn't add anything here
There was a problem hiding this comment.
agg is using shared_docs. I was avoiding to copy it and make a single line change. Will remove it only if no objection
|
lgtm @ihsansecer ping on green. |
|
thanks @ihsansecer |
|
btw now that pandas/tests/window/ exists would love to split test_window even more :-> |
|
@jreback noted :) |
git diff upstream/master -u -- "*.py" | flake8 --diffWeighted std could be implemented but there are also other functions weighted
Windowis lacking.